Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes timestamp parsing docs clearer #2360

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Makes timestamp parsing docs clearer #2360

merged 1 commit into from
Jul 16, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jul 16, 2020

Hopefully helps confusion wrt custom formats that need to use the reference time such as #2354

@codecov-commenter
Copy link

Codecov Report

Merging #2360 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2360   +/-   ##
=======================================
  Coverage   61.50%   61.50%           
=======================================
  Files         160      160           
  Lines       13534    13534           
=======================================
  Hits         8324     8324           
  Misses       4585     4585           
  Partials      625      625           
Impacted Files Coverage Δ
pkg/promtail/targets/file/tailer.go 78.40% <0.00%> (ø)

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 35b61e6 into master Jul 16, 2020
@cyriltovena cyriltovena deleted the owen-d-patch-1 branch July 16, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants