Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: moved jaeger-agent-mixin #2377

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Conversation

Duologic
Copy link
Member

What this PR does / why we need it:

jaeger-agent-mixin was part of ksonnet-util, but that was a bit out of place and now is its own lib.

jb-0.4.0 has updated the jsonnetfile.json format, just following upstream here.

Which issue(s) this PR fixes:
none

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #2377 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2377   +/-   ##
=======================================
  Coverage   61.65%   61.65%           
=======================================
  Files         160      160           
  Lines       13565    13565           
=======================================
  Hits         8363     8363           
  Misses       4579     4579           
  Partials      623      623           

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@owen-d owen-d merged commit 96515e3 into master Jul 20, 2020
@owen-d owen-d deleted the duologic/use_jaeger-agent-mixin branch July 20, 2020 14:34
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants