fluentd: Make fluentd version requirements permissive #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarokkk
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2399 +/- ##
==========================================
- Coverage 61.72% 61.71% -0.02%
==========================================
Files 160 160
Lines 13577 13577
==========================================
- Hits 8381 8379 -2
- Misses 4569 4570 +1
- Partials 627 628 +1
|
|
@cyriltovena Thanks for the rapid review! Could you please let me know how/when it will released into the rubygems repo? Thanks for your support! |
|
will do now. |
|
ho you did not update the gem version :/ let me try to yank it. |
|
ho that didn't work. well I need to push a new version |
|
Thanks I forgot that my bad :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR reverts the change to use a fixed Fluentd version. As a plugin, it is counterproductive to fix a very specific version of Fluentd.
Special notes for your reviewer:
Checklist