BatchIter edge cases #2466
Merged
BatchIter edge cases #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2466 +/- ##
==========================================
+ Coverage 62.80% 62.86% +0.05%
==========================================
Files 162 162
Lines 13966 13975 +9
==========================================
+ Hits 8772 8786 +14
+ Misses 4512 4506 -6
- Partials 682 683 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues in the batch iterator code, including:
Ensure calls to
MemChunk.Blocksare inclusive. This is particularly helpful when they contain a single entry which has been requested in the batching code. At this point it's unknown whether the call is looking for[start,end)or(start,end], dependent onlogproto.Direction. This is handled at a higher layer via theTimeBoundedIter, so we should handle these requests inclusively for now. I found it stripping logs whenstart=endwas requested.Only include previously overlapping chunks one time per batch. In rare cases, it could previously add these repeatedly on a loop, effectively duplicating references to the same chunks within a single batch.
Fixes sample iterator from deleting a regular iterator in the memchunk cache map.
Fixes metric name in a test utility.
Thanks to the wondrous @rfratto for spotting the embedded field race condition.