series endpoint uses normal splits #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
force-pushed
the
fix/series-splits
branch
from
c330725
to
470c9f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hardcoded series splitby to 24h recently to align with the 24h index buckets
https://github.com/grafana/loki/blob/master/pkg/querier/queryrange/roundtrip.go#L265-L266
We can see that the index time is pretty short, but we’re fetching too many chunks.
Also there’s no guarantee and in fact it’s incredibly unlikely that a 24h split will align with 1 daily bucket (it’s much more likely that the start/end of the split is between bucket bounds, which would spill into another bucket).
I think we can decrease the splitby for these reasons.