Promtail: Fail fast if promtail can't fail the file #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cause the tail to fail fast and allow promtail to attempt to re-open the file.
Codecov Report
@@ Coverage Diff @@
## master #2491 +/- ##
==========================================
- Coverage 63.29% 63.19% -0.11%
==========================================
Files 162 162
Lines 14114 14115 +1
==========================================
- Hits 8934 8920 -14
- Misses 4470 4487 +17
+ Partials 710 708 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable the MustExist flag when starting a tailer on a fail, this will cause the tail to fail fast and allow promtail to attempt to re-open the file.
Fixes #1325