Jsonnet Promtail: Change function for mounting configmap in promtail daemonset #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2494 +/- ##
==========================================
- Coverage 63.32% 63.22% -0.11%
==========================================
Files 162 162
Lines 14115 14115
==========================================
- Hits 8939 8924 -15
- Misses 4467 4484 +17
+ Partials 709 707 -2
|
slim-bean
approved these changes
Aug 14, 2020
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
…na#2494) * return directories in respose from List calls to object stores Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * changes suggested from PR review Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This version of the configmap mount function add an HASH of the configmap to the promtail daemonset so to trigger a reload
when the configuration change
Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist