Consistent chunk metrics #2534
Merged
Consistent chunk metrics #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2534 +/- ##
==========================================
- Coverage 63.68% 63.57% -0.11%
==========================================
Files 163 163
Lines 14305 14310 +5
==========================================
- Hits 9110 9098 -12
- Misses 4481 4499 +18
+ Partials 714 713 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the initial implementation of chunk metrics and attempts to make them consistent and more usable by queries/dashboards wishing to show things like:
discarded refs %discarded series %discarded chunks %discarded chunks per batch histogramspost-filter refs %post-filter series %post-filter chunks %post-fillter chunks ber patch histograms (effective batch size)