register boltdb shipper compactor cli flags #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2546 +/- ##
==========================================
- Coverage 63.46% 63.43% -0.04%
==========================================
Files 166 166
Lines 14582 14583 +1
==========================================
- Hits 9254 9250 -4
- Misses 4586 4597 +11
+ Partials 742 736 -6
|
slim-bean
approved these changes
Aug 27, 2020
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
…a#2546) * provisioning of table for delete requests using table manager Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * changes suggested from PR review Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * generate doc Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * fixed tag for delete store config Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * changes suggested from PR review Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Register boltdb shipper compactor cli flags.
I have also changed flag names to have a prefix to be able to associate flags with the component that they belong to.
It also fixes a bug in the listing of dbs from tables in hosted object stores.