add some metrics for monitoring compactor #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepsukhani
force-pushed
the
compactor-metrics
branch
2 times, most recently
from
39ae984
to
8f96078
Compare
sandeepsukhani
force-pushed
the
compactor-metrics
branch
from
8f96078
to
79a1706
Compare
Codecov Report
@@ Coverage Diff @@
## master #2548 +/- ##
=======================================
Coverage 62.98% 62.98%
=======================================
Files 168 169 +1
Lines 14879 14902 +23
=======================================
+ Hits 9371 9386 +15
- Misses 4762 4768 +6
- Partials 746 748 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds metrics for monitoring the number of failed/successful attempts in compaction and the amount of time it took to compact all the tables in seconds.