Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

production/helm: add support for PV selector in Loki statefulset #2554

Merged

Conversation

alexandre-allard
Copy link
Contributor

Add support to select PV by labels in Loki StatefulSet volumeClaimTemplates.

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #2554 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2554   +/-   ##
=======================================
  Coverage   62.98%   62.98%           
=======================================
  Files         168      168           
  Lines       14879    14879           
=======================================
  Hits         9371     9371           
  Misses       4762     4762           
  Partials      746      746           

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@owen-d owen-d merged commit c2e610b into grafana:master Sep 10, 2020
@alexandre-allard alexandre-allard deleted the loki-helm-chart-support-pvc-selector branch September 14, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants