Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate max_query_length in Labels API #2572

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

adityacs
Copy link
Collaborator

What this PR does / why we need it:
Validate max_query_length in Labels API

Which issue(s) this PR fixes:
Fixes #1747

@codecov-commenter
Copy link

Codecov Report

Merging #2572 into master will decrease coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2572      +/-   ##
==========================================
- Coverage   62.85%   62.84%   -0.01%     
==========================================
  Files         169      169              
  Lines       14913    14915       +2     
==========================================
  Hits         9374     9374              
- Misses       4790     4792       +2     
  Partials      749      749              
Impacted Files Coverage Δ
pkg/querier/querier.go 62.71% <20.00%> (-0.37%) ⬇️
pkg/querier/queryrange/downstreamer.go 95.87% <0.00%> (-2.07%) ⬇️
pkg/logql/evaluator.go 92.88% <0.00%> (+0.40%) ⬆️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slim-bean slim-bean merged commit c1f07f0 into grafana:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply request length limit to label and series queries.
3 participants