Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix closing of compressed file from boltdb-shipper compactor #2574

Merged

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
Fix a mistake in code trying to close uncompressed file again instead of compressed one.

@codecov-commenter
Copy link

Codecov Report

Merging #2574 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2574   +/-   ##
=======================================
  Coverage   62.85%   62.85%           
=======================================
  Files         169      169           
  Lines       14913    14913           
=======================================
  Hits         9374     9374           
  Misses       4790     4790           
  Partials      749      749           
Impacted Files Coverage Δ
pkg/storage/stores/shipper/util/util.go 43.63% <0.00%> (-3.64%) ⬇️
pkg/logql/evaluator.go 92.88% <0.00%> (+0.40%) ⬆️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sandeepsukhani sandeepsukhani merged commit 7566aa4 into grafana:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants