Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #2579

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Update CODEOWNERS #2579

merged 1 commit into from
Aug 31, 2020

Conversation

oddlittlebird
Copy link
Contributor

What this PR does / why we need it: Add our new tech writer to the Loki docs as a codeowner. @achatterjee-grafana

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@codecov-commenter
Copy link

Codecov Report

Merging #2579 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2579      +/-   ##
==========================================
+ Coverage   63.03%   63.05%   +0.02%     
==========================================
  Files         169      169              
  Lines       15005    15005              
==========================================
+ Hits         9458     9461       +3     
+ Misses       4794     4784      -10     
- Partials      753      760       +7     
Impacted Files Coverage Δ
pkg/promtail/targets/file/tailer.go 70.83% <0.00%> (-4.17%) ⬇️
pkg/promtail/targets/file/filetarget.go 66.85% <0.00%> (-2.29%) ⬇️
pkg/querier/queryrange/downstreamer.go 95.87% <0.00%> (-2.07%) ⬇️
pkg/logql/evaluator.go 92.47% <0.00%> (-0.41%) ⬇️
pkg/promtail/positions/positions.go 59.64% <0.00%> (+13.15%) ⬆️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slim-bean slim-bean merged commit e1ee189 into master Aug 31, 2020
@slim-bean slim-bean deleted the make-jita-codeowner branch August 31, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants