Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict rule unmarshaling #2580

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Aug 31, 2020

Ensures that unmentioned fields error instead of being ignored silently.

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #2580 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2580      +/-   ##
==========================================
- Coverage   63.03%   63.00%   -0.03%     
==========================================
  Files         169      169              
  Lines       15005    15005              
==========================================
- Hits         9458     9454       -4     
- Misses       4794     4796       +2     
- Partials      753      755       +2     
Impacted Files Coverage Δ
pkg/ruler/manager/compat.go 49.68% <100.00%> (+2.54%) ⬆️
pkg/promtail/targets/file/tailer.go 70.83% <0.00%> (-4.17%) ⬇️
pkg/promtail/targets/file/filetarget.go 66.85% <0.00%> (-2.29%) ⬇️

@owen-d owen-d merged commit 4032c92 into grafana:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants