Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _total suffix to ruler counter metrics #2582

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Aug 31, 2020

Signed-off-by: Ben Ye yb532204897@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Ben Ye <yb532204897@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2582 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2582      +/-   ##
==========================================
+ Coverage   63.00%   63.11%   +0.10%     
==========================================
  Files         169      169              
  Lines       15005    15005              
==========================================
+ Hits         9454     9470      +16     
+ Misses       4796     4781      -15     
+ Partials      755      754       -1     
Impacted Files Coverage Δ
pkg/ruler/manager/memstore.go 68.25% <100.00%> (ø)
pkg/querier/queryrange/downstreamer.go 95.87% <0.00%> (-2.07%) ⬇️
pkg/promtail/targets/file/filetarget.go 66.28% <0.00%> (-0.58%) ⬇️
pkg/promtail/targets/file/tailer.go 75.00% <0.00%> (+4.16%) ⬆️
pkg/promtail/positions/positions.go 59.64% <0.00%> (+13.15%) ⬆️

@slim-bean
Copy link
Collaborator

Thanks Ben! could you also update the dashboards: ksonnet/lib/loki-cloud-mixin/ruler-dashboard.libsonnet with the fixed metric name?

@yeya24
Copy link
Contributor Author

yeya24 commented Sep 2, 2020

Hi @slim-bean, I am sorry I cannot find the file you mentioned. Is it in the production/ksonnet directory? I cannot find any ruler-dashboard.libsonnet file in Loki repo.

@slim-bean
Copy link
Collaborator

Sorry, looks like my search hit code in a different repo! you are good to go!

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slim-bean slim-bean merged commit 900f714 into grafana:master Sep 3, 2020
@yeya24 yeya24 deleted the rename-rule-metrics branch September 3, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants