Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup: url to access promtail config sample #2597

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

nek-00-ken
Copy link
Contributor

@nek-00-ken nek-00-ken commented Sep 3, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #2597 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2597      +/-   ##
==========================================
- Coverage   63.03%   62.97%   -0.06%     
==========================================
  Files         169      169              
  Lines       15015    15015              
==========================================
- Hits         9464     9456       -8     
- Misses       4792     4804      +12     
+ Partials      759      755       -4     
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 46.49% <0.00%> (-13.16%) ⬇️
pkg/promtail/targets/file/tailer.go 72.91% <0.00%> (+2.08%) ⬆️
pkg/promtail/targets/file/filetarget.go 69.14% <0.00%> (+2.85%) ⬆️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@slim-bean
Copy link
Collaborator

Looks like you need to sign the CLA still, (or if you did it usually goes wrong because the email on your git commit doesn't match the email you use in github, if this is the case usually the easiest fix is to modify the author email on the existing commit and force push to the branch)

@nek-00-ken
Copy link
Contributor Author

nek-00-ken commented Sep 4, 2020

Hi, I ament the commit, thanks for the advice about the mail, I didn't know about it ! CLA approved ;)
@slim-bean : You're welcome ! anybody who uses the stack and the provided documentation should have fix this for a while... :P

@slim-bean
Copy link
Collaborator

Thanks @nek-00-ken!

@slim-bean slim-bean merged commit d03983d into grafana:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants