rpc for querying ingesters to get chunk ids from its store #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepsukhani
force-pushed
the
query-ingester-chunk-ids
branch
from
b932b0f
to
9fd20fd
Compare
sandeepsukhani
force-pushed
the
query-ingester-chunk-ids
branch
3 times, most recently
from
e61058a
to
a21b78b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2601 +/- ##
==========================================
- Coverage 62.87% 61.41% -1.47%
==========================================
Files 170 172 +2
Lines 15051 13312 -1739
==========================================
- Hits 9464 8175 -1289
+ Misses 4827 4394 -433
+ Partials 760 743 -17
|
slim-bean
reviewed
Sep 14, 2020
slim-bean
reviewed
Sep 15, 2020
slim-bean
reviewed
Sep 15, 2020
slim-bean
reviewed
Sep 15, 2020
slim-bean
reviewed
Sep 15, 2020
sandeepsukhani
force-pushed
the
query-ingester-chunk-ids
branch
2 times, most recently
from
9303b3a
to
c45fa56
Compare
sandeepsukhani
requested review from
achatterjee-grafana and
oddlittlebird
as code owners
slim-bean
previously approved these changes
Sep 16, 2020
There was a problem hiding this comment.
I think this looks good @sandeepsukhani, some feedback from @oddlittlebird to address but lets get this merged!
slim-bean
dismissed
their stale review
found something i think we need to fix
slim-bean
reviewed
Sep 16, 2020
sandeepsukhani
force-pushed
the
query-ingester-chunk-ids
branch
from
3810578
to
0317f58
Compare
…h chunk store and ingesters
…db-shipper or query store is true
1. query chunk-refs parallely from store and ingesters. 2. limit look back for chunk refs and labels from ingesters to start of schema when using boltdb-shipper.
…ngester or querier
sandeepsukhani
force-pushed
the
query-ingester-chunk-ids
branch
from
66149e1
to
2946f52
Compare
slim-bean
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When using boltdb shipper ingesters have to serve logs from the store as well to include logs from chunks which are flushed but its index might not be uploaded yet. Due to this extra workload, ingesters are OOMing when someone runs a huge query.
To avoid this we need to offload the workload of logs processing to queriers. This can be done by adding a new RPC to ingesters to let queriers query for IDs of the chunks which were already flushed to the store.
This is still a draft PR to discuss the RPC definition. The actual implementation would follow.
Checklist