Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/storage/stores/shipper/uploads: fix test error #2620

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Sep 13, 2020

This fixes a dropped err variable in the tests for pkg/storage/stores/shipper/uploads.

Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Sep 13, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #2620 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2620      +/-   ##
==========================================
+ Coverage   62.87%   62.94%   +0.06%     
==========================================
  Files         170      170              
  Lines       15049    15049              
==========================================
+ Hits         9462     9472      +10     
+ Misses       4826     4821       -5     
+ Partials      761      756       -5     
Impacted Files Coverage Δ
pkg/logql/evaluator.go 92.88% <0.00%> (+0.40%) ⬆️
pkg/promtail/targets/file/filetarget.go 69.14% <0.00%> (+2.28%) ⬆️
pkg/promtail/targets/file/tailer.go 75.00% <0.00%> (+4.16%) ⬆️

Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@sandeepsukhani sandeepsukhani merged commit 334cc1e into grafana:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants