Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart: Fix broken logo #2651

Merged
merged 3 commits into from Nov 4, 2020
Merged

helm chart: Fix broken logo #2651

merged 3 commits into from Nov 4, 2020

Conversation

scottrigby
Copy link
Contributor

What this PR does / why we need it:
The log has moved, so Chart.yaml logo is incorrect. This causes tools like CNCF Artifact Hub to fail displaying the logo.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Similar to #2385

Checklist
- [ ] Documentation added
- [ ] Tests updated

The log has moved, so Chart.yaml logo is incorrect. This causes tools like CNCF Artifact Hub to fail displaying the logo.
@CLAassistant
Copy link

CLAassistant commented Sep 21, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #2651 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2651      +/-   ##
==========================================
- Coverage   61.22%   61.18%   -0.05%     
==========================================
  Files         172      172              
  Lines       13360    13360              
==========================================
- Hits         8180     8174       -6     
- Misses       4431     4438       +7     
+ Partials      749      748       -1     
Impacted Files Coverage Δ
pkg/promtail/targets/file/filetarget.go 61.97% <0.00%> (-4.23%) ⬇️

@slim-bean
Copy link
Collaborator

Thanks @scottrigby!

Could you also bump the loki-stack chart patch version too?

@scottrigby
Copy link
Contributor Author

@slim-bean sure, do you want that as a separate PR?

@slim-bean
Copy link
Collaborator

same PR, thanks!

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to bump the umbrella chart loki-stack.

@stale
Copy link

stale bot commented Oct 30, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Oct 30, 2020
@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Nov 4, 2020
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Nov 4, 2020
@cyriltovena cyriltovena merged commit f3ae1f6 into grafana:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants