[Promtail] enables configuring psp in helm chart #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2659 +/- ##
=======================================
Coverage 61.28% 61.28%
=======================================
Files 172 172
Lines 13360 13360
=======================================
Hits 8188 8188
Misses 4419 4419
Partials 753 753 |
|
hey @rskrishnar thanks for the PR! I think this should be a configurable option with the default values left to false as they were originally and if someone wants to enable this they can do so in their values.yaml file. I believe by forcing these to true many users would no longer be able to run promtail in environments which don't allow these policies. I think the safer approach is to leave it false and allow people to turn them to true if they would like to. |
rskrishnar
force-pushed
the
allow-privileged-containers-in-psp
branch
from
d11af51
to
d5b628e
Compare
|
@slim-bean yes I agree. added the default values to values.yaml. |
cyriltovena
approved these changes
Sep 29, 2020
rskrishnar
force-pushed
the
allow-privileged-containers-in-psp
branch
from
f64b1c3
to
33d3ec1
Compare
rskrishnar
changed the title
|
@cyriltovena bumped the loki-stack helm chart version. Also updated the PR title for more clarity. |
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Oct 21, 2020
* makes pod security policy configurable * bump promtail chart version * bump loki-stack chart version Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2630
Special notes for your reviewer:
Checklist