Enable local rules backend & disallow configdb. #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2661 +/- ##
==========================================
- Coverage 61.28% 61.16% -0.12%
==========================================
Files 172 172
Lines 13360 13363 +3
==========================================
- Hits 8188 8174 -14
- Misses 4419 4440 +21
+ Partials 753 749 -4
|
|
Why disallowing the configdb option? I have use this feature in my env and I think this a very good and useful feature. Cortex ruler still support configdb in lastest edition. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in some upstream changes from Cortex which allow us to load loki rules via the
localfilesystem rules backend type. In addition to disallowing theconfigdboption, all ruler backend types should be compatible with logql.There's also a few compatibility changes due to upstream interface additions/etc.