Loki: Querier APIs respond JSON Content-Type #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #2665 +/- ##
==========================================
- Coverage 61.46% 61.44% -0.02%
==========================================
Files 173 173
Lines 13421 13428 +7
==========================================
+ Hits 8249 8251 +2
- Misses 4422 4428 +6
+ Partials 750 749 -1
|
|
Nice should the query-frontend have the same middleware ? Can you also sign the CLA. Again thank you ! |
I think there should be. Has been signed. |
cyriltovena
approved these changes
Sep 29, 2020
cyriltovena
reviewed
Sep 29, 2020
pkg/util/server/middleware.go
Outdated
| func ResponseJSONMiddleware() middleware.Interface { | ||
| return middleware.Func(func(next http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) { | ||
| w.Header().Add("Content-Type", "application/json; charset=UTF-8") |
There was a problem hiding this comment.
I wonder if Set would be better here ? So that whatever it was it is replaced. Pretty sure it's no a big deal here, I'll merge it as is tomorrow if you don't have time to make the change.
There was a problem hiding this comment.
You're right. This should be a replacement, not an Add. I'll fix it right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add json response so that http client tool can display data better.