Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use repetitive numbering #2699

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

sandangel
Copy link
Contributor

What this PR does / why we need it:
I would like to contribute to this repo during the Hacktofest
What it does: Refactor docs to use repetitive numbering

Which issue(s) this PR fixes:
Fixes #2681

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #2699 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2699      +/-   ##
==========================================
- Coverage   61.46%   61.39%   -0.07%     
==========================================
  Files         173      173              
  Lines       13421    13421              
==========================================
- Hits         8249     8240       -9     
- Misses       4421     4427       +6     
- Partials      751      754       +3     
Impacted Files Coverage Δ
pkg/promtail/targets/file/tailer.go 68.53% <0.00%> (-4.50%) ⬇️
pkg/querier/queryrange/downstreamer.go 95.29% <0.00%> (-2.36%) ⬇️
pkg/promtail/targets/file/filetarget.go 64.08% <0.00%> (-2.12%) ⬇️

Copy link
Contributor

@oddlittlebird oddlittlebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one of the Loki maintainers needs to approve as well.

Thank you!

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@owen-d owen-d merged commit c00c7ed into grafana:master Sep 30, 2020
@sandangel sandangel deleted the doc/repetitive-numbering branch October 1, 2020 07:34
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Oct 21, 2020
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply lazy numbering
5 participants