Doc: fix broken links in production/README.md #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #2702 +/- ##
==========================================
- Coverage 61.41% 61.33% -0.09%
==========================================
Files 173 173
Lines 13444 13444
==========================================
- Hits 8257 8246 -11
- Misses 4430 4443 +13
+ Partials 757 755 -2
|
|
Thanks for the PR @huikang! we love it when people improve errors in our docs ❤️ Our doc situation got a little bit screwed up when we moved the docs to https://grafana.com/docs/loki We have been trying to remove all links which directly reference the github contents as these will not render very well anymore now that we have hugo frontmatter and they are no longer named README. Could you update these links instead to be links to the grafana.com docs? e.g. https://grafana.com/docs/loki/latest/logql/ and https://grafana.com/docs/loki/latest/getting-started/grafana/ Thanks! |
- point to the grafana/loki doc website Signed-off-by: Hui Kang <kangh@us.ibm.com>
huikang
force-pushed
the
fix-broken-link
branch
from
89eb438
to
ed127d2
Compare
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Oct 21, 2020
- point to the grafana/loki doc website Signed-off-by: Hui Kang <kangh@us.ibm.com> Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hui Kang kangh@us.ibm.com