Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAL design doc #2704

Merged
merged 3 commits into from
Nov 5, 2020
Merged

WAL design doc #2704

merged 3 commits into from
Nov 5, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Sep 30, 2020

First draft of a WAL design for Loki.

@codecov-commenter
Copy link

Codecov Report

Merging #2704 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2704      +/-   ##
==========================================
- Coverage   61.48%   61.40%   -0.09%     
==========================================
  Files         173      173              
  Lines       13412    13412              
==========================================
- Hits         8246     8235      -11     
- Misses       4411     4423      +12     
+ Partials      755      754       -1
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️
pkg/logql/evaluator.go 92.38% <0.00%> (-0.43%) ⬇️
pkg/querier/queryrange/downstreamer.go 97.64% <0.00%> (+2.35%) ⬆️

@cyriltovena cyriltovena added this to To do in Loki Project Oct 27, 2020
@cyriltovena cyriltovena moved this from To do to In progress in Loki Project Oct 27, 2020
@owen-d owen-d mentioned this pull request Oct 29, 2020
Closed
@stale
Copy link

stale bot commented Oct 31, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Oct 31, 2020
@kavirajk kavirajk added keepalive An issue or PR that will be kept alive and never marked as stale. and removed stale A stale issue or PR that will automatically be closed. labels Oct 31, 2020
cyriltovena
cyriltovena approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Loki Project automation moved this from In progress to Reviewer approved Nov 5, 2020
@owen-d owen-d merged commit 9d213fb into grafana:master Nov 5, 2020
Loki Project automation moved this from Reviewer approved to Done Nov 5, 2020
@cyriltovena cyriltovena mentioned this pull request Nov 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

@achatterjee-grafana achatterjee-grafana Awaiting requested review from achatterjee-grafana

@oddlittlebird oddlittlebird Awaiting requested review from oddlittlebird

Assignees
No one assigned
Labels
keepalive An issue or PR that will be kept alive and never marked as stale. size/L
Projects
Loki Project
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@owen-d @codecov-commenter @cyriltovena @kavirajk