Deprecate Charts as they have been moved #2720
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #2720 +/- ##
=======================================
Coverage 61.40% 61.40%
=======================================
Files 173 173
Lines 13446 13446
=======================================
Hits 8257 8257
Misses 4431 4431
Partials 758 758 |
torstenwalter
force-pushed
the
deprecate-charts
branch
from
ea10f61
to
bfba0f9
Compare
There was a problem hiding this comment.
@torstenwalter This looks great. Since these charts will not become "un-deprecated" here, do you want to make a follow-up PR to remove the source code from this repo per https://helm.sh/docs/topics/charts/#deprecating-charts?
If you prefer to leave the deprecated source code here, would you instead also add a deprecation note to the templates/NOTES.txt file in each of these charts?
|
It'd be nice to remove the source eventually as @scottrigby suggested. All in all, looks great! |
|
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
@owen-d @scottrigby does it make sense to deprecate the charts here at all or should we simple remove the source code here and leave a note where to find it instead? |
stale
bot
removed
the
stale
Signed-off-by: Torsten Walter <torsten.walter@syncier.com>
torstenwalter
force-pushed
the
deprecate-charts
branch
from
bfba0f9
to
47ae69e
Compare
|
We want to at least create a release to the repo with a deprecated version, so that existing users will have a way to know where to migrate to for future versions. |
|
Makes sense. This PR is already updated to do that. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2593
Special notes for your reviewer:
This should only be merged once grafana/helm-charts#39 is merged and we confirmed that everything is working.
Checklist