Promtail: Add counter promtail_batch_retries_total #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calle Pettersson <calle@cape.nu>
Codecov Report
@@ Coverage Diff @@
## master #2723 +/- ##
==========================================
- Coverage 61.36% 61.35% -0.01%
==========================================
Files 173 173
Lines 13463 13465 +2
==========================================
Hits 8261 8261
- Misses 4447 4449 +2
Partials 755 755
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently there is only a metric for dropped batches. It'd be helpful to alert on things going wrong before there is data loss. This PR adds a counter on batch send retries.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Checklist