set timestamp in instant query done by canaries #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set to now by loki
Codecov Report
@@ Coverage Diff @@
## master #2732 +/- ##
==========================================
- Coverage 61.37% 61.35% -0.03%
==========================================
Files 173 173
Lines 13465 13465
==========================================
- Hits 8264 8261 -3
- Misses 4447 4449 +2
- Partials 754 755 +1
|
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
…2732) * Add validation check for chunks and index Prefix This change would add a check if chunks and index prefix in schema config exists. Signed-off-by: Jay Batra <jaybatra73@gmail.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We do not set a timestamp in instant queries being done by canaries so loki defaults it to
time.Now().This causes 2 identical loki servers to return a different timestamp in response when running behind query tee and hence treating it as a failure in getting the same response.