Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting errors and use of deprecated repositories #2742

Merged
merged 3 commits into from
Oct 12, 2020

Conversation

steven-sheehy
Copy link
Contributor

@steven-sheehy steven-sheehy commented Oct 8, 2020

What this PR does / why we need it:

  • Switch away from deprecated chart repositories
  • Bump dependencies to fix linting errors when mixing loki with kube-prometheus-stack
Error:  templates/: template: charts/loki-stack/charts/grafana/templates/deployment.yaml:48:10: executing "loki-stack/charts/grafana/templates/deployment.yaml" at <include "grafana.pod" .>: error calling include: template: kube-prometheus-stack/charts/grafana/templates/_pod.tpl:18:102: executing "grafana.pod" at <.Values.sidecar.notifiers.enabled>: nil pointer evaluating interface {}.enabled

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy
Copy link
Contributor Author

Side note: Are there plans to move Loki chart to https://github.com/grafana/helm-charts as well or will it stay in this repo?

@codecov-io
Copy link

Codecov Report

Merging #2742 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2742      +/-   ##
==========================================
- Coverage   61.39%   61.36%   -0.03%     
==========================================
  Files         173      173              
  Lines       13465    13465              
==========================================
- Hits         8267     8263       -4     
- Misses       4445     4448       +3     
- Partials      753      754       +1     
Impacted Files Coverage Δ
pkg/promtail/targets/file/tailer.go 70.09% <0.00%> (-5.61%) ⬇️
pkg/logql/evaluator.go 92.81% <0.00%> (+0.42%) ⬆️

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @steven-sheehy

@cyriltovena cyriltovena merged commit 8641149 into grafana:master Oct 12, 2020
@steven-sheehy steven-sheehy deleted the bump-chart-deps branch October 12, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants