Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm/fluentbit K8S-Logging.Exclude & and Mem_Buf_Limit toggle #2746

Merged
merged 1 commit into from
Oct 16, 2020
Merged

helm/fluentbit K8S-Logging.Exclude & and Mem_Buf_Limit toggle #2746

merged 1 commit into from
Oct 16, 2020

Conversation

marcosartori
Copy link
Contributor

@marcosartori marcosartori commented Oct 9, 2020

What this PR does / why we need it:
Adds the ability to set K8S-Logging.Exclude for stopping logs getting to loki (default Off like it is now)
Adds the ability to set Mem_Buf_Limit to any value you want (default 5MB)

Which issue(s) this PR fixes:
n/a its something that I need and figure others might want this

Special notes for your reviewer:
when I run make helm and deplyo fluent-bit this (not my change)

batchSize: 1048576

gets converted and then prevents starting (so I quoted it locally and built the chart to make it work, didn't add that to the pr though, however I pretty sure its not correct so can fix at same time by quoting if you guys wish)

I think I catered for everything I used vim to edit as my vscode linter was basically changing everything, so would be great to know what one is used here so I can follow.

I updated the readme, I have deployed to a k3d cluster and looked good

loki-promtail-j4shw          1/1     Running   0          24m
loki-promtail-mr7p7          1/1     Running   0          24m
loki-0                       1/1     Running   0          24m
loki-fluent-bit-loki-hp2wt   1/1     Running   0          23m
loki-fluent-bit-loki-dfbm2   1/1     Running   0          23m

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. and yes I'd like that PR to fix the quote of batch size ✌️

@cyriltovena cyriltovena merged commit 9d2f827 into grafana:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants