fix: Remove depricated entry_parser from scrapeconfig
#2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavirajk
requested review from
achatterjee-grafana and
oddlittlebird
as code owners
|
|
kavirajk
force-pushed
the
fix/remove-entry-parser
branch
3 times, most recently
from
c35dfc1
to
fb56d92
Compare
kavirajk
changed the title
entry_parser from scrapeconfigentry_parser from scrapeconfig
kavirajk
force-pushed
the
fix/remove-entry-parser
branch
from
fb56d92
to
3f01b4a
Compare
kavirajk
commented
Oct 13, 2020
| @@ -82,7 +80,11 @@ type PushTargetConfig struct { | |||
|
|
|||
| // DefaultScrapeConfig is the default Config. | |||
| var DefaultScrapeConfig = Config{ | |||
| EntryParser: api.Docker, | |||
| PipelineStages: []interface{}{ | |||
There was a problem hiding this comment.
[q]: unfortunately coz the type of pipeline stages are just []interface{}. Would love to know if there is a better way!
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Oct 21, 2020
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To remove deprecated
entry_parserconfig and replace it withpipeline_stageseverywhere.Which issue(s) this PR fixes:
Fixes #2631 #2577
Special notes for your reviewer:
remove deprecated
entry_parserfrom scrapeconfig. use pipeline_stages instead.Checklist