Boltdb shipper metrics changes #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slim-bean
reviewed
Oct 23, 2020
| @@ -163,10 +163,20 @@ func (tm *TableManager) getOrCreateTable(spanCtx context.Context, tableName stri | |||
| return table | |||
| } | |||
|
|
|||
| func (tm *TableManager) syncTables(ctx context.Context) error { | |||
| func (tm *TableManager) syncTables(ctx context.Context) (err error) { | |||
There was a problem hiding this comment.
I prefer the other style of not defining the variable name in the method.
This is usually how we do it and I like that return nil at the end is a little more explicit.
Codecov Report
@@ Coverage Diff @@
## master #2790 +/- ##
==========================================
- Coverage 61.35% 61.30% -0.05%
==========================================
Files 177 177
Lines 14378 14387 +9
==========================================
- Hits 8821 8820 -1
- Misses 4748 4755 +7
- Partials 809 812 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
tablein their names instead offiles.tables_sync_operation_totalmetric during periodic sync operations to be able to detect problems and write alerts on it.