Fixes a bug that would add __error__ label incorrectly. #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong usage of slices would add error label to the original set of labels. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2796 +/- ##
==========================================
- Coverage 61.42% 61.39% -0.03%
==========================================
Files 177 177
Lines 14373 14373
==========================================
- Hits 8828 8825 -3
- Misses 4738 4740 +2
- Partials 807 808 +1
|
cyriltovena
added a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Fixes an issue in the index chunks/series intersect code. This was introduce in grafana#2700, more specifically this line https://github.com/cortexproject/cortex/pull/2700/files#diff-10bca0f4f31a2ca1edc507d0289b143dR537 This causes any query with the first label matcher not matching anything to return all matches of all other labels. This is a nasty one since, the code was relying on empty slice, and so it would skip nil values instead of returning no matches. I've added a regression test proving this is fixed everywhere. I think in cortex it can probably affect performance (since you have to download all chunk not required) but not read integrity. I have found this with @slim-bean while deploying Loki, all queriers where OOMing because of this. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Update changelog. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
added a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Fixes an issue in the index chunks/series intersect code. This was introduce in grafana#2700, more specifically this line https://github.com/cortexproject/cortex/pull/2700/files#diff-10bca0f4f31a2ca1edc507d0289b143dR537 This causes any query with the first label matcher not matching anything to return all matches of all other labels. This is a nasty one since, the code was relying on empty slice, and so it would skip nil values instead of returning no matches. I've added a regression test proving this is fixed everywhere. I think in cortex it can probably affect performance (since you have to download all chunk not required) but not read integrity. I have found this with @slim-bean while deploying Loki, all queriers where OOMing because of this. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Update changelog. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong usage of slices would add error label to the original set of labels.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com