Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: Update update document links to point to the right place. #2810

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

hedss
Copy link
Contributor

@hedss hedss commented Oct 26, 2020

Signed-off-by: Heds Simons heds@whaleway.net

What this PR does / why we need it:
Links to the update docs in the changelog were incorrect.

Which issue(s) this PR fixes:
Small change, no issue raised.

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2020

CLA assistant check
All committers have signed the CLA.

@hedss hedss requested review from slim-bean and cyriltovena and removed request for slim-bean October 26, 2020 16:15
@codecov-io
Copy link

Codecov Report

Merging #2810 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2810      +/-   ##
==========================================
+ Coverage   61.34%   61.35%   +0.01%     
==========================================
  Files         179      179              
  Lines       14438    14438              
==========================================
+ Hits         8857     8859       +2     
+ Misses       4773     4770       -3     
- Partials      808      809       +1     
Impacted Files Coverage Δ
pkg/storage/stores/shipper/uploads/table.go 68.66% <0.00%> (-1.85%) ⬇️
...kg/storage/stores/shipper/uploads/table_manager.go 65.78% <0.00%> (-1.76%) ⬇️
pkg/querier/queryrange/downstreamer.go 97.64% <0.00%> (+2.35%) ⬆️
pkg/promtail/targets/file/tailer.go 75.23% <0.00%> (+5.71%) ⬆️

Signed-off-by: Heds Simons <heds@whaleway.net>
@hedss hedss force-pushed the changelog-update-docs-link-fixes branch from bca964f to f2fad0e Compare October 26, 2020 16:29
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit 9ccfeca into master Oct 26, 2020
@slim-bean slim-bean deleted the changelog-update-docs-link-fixes branch October 26, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants