Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates docs with delete permissions notice #2819

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Oct 27, 2020

No description provided.

@achatterjee-grafana
Copy link
Contributor

@oddlittlebird, looking at this now.

@codecov-io
Copy link

Codecov Report

Merging #2819 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2819   +/-   ##
=======================================
  Coverage   61.30%   61.30%           
=======================================
  Files         179      179           
  Lines       14438    14438           
=======================================
  Hits         8851     8851           
- Misses       4775     4779    +4     
+ Partials      812      808    -4     
Impacted Files Coverage Δ
pkg/promtail/targets/file/filetarget.go 61.97% <0.00%> (-4.23%) ⬇️
...kg/storage/stores/shipper/uploads/table_manager.go 67.54% <0.00%> (+1.75%) ⬆️
pkg/storage/stores/shipper/uploads/table.go 70.50% <0.00%> (+1.84%) ⬆️

Copy link
Contributor

@achatterjee-grafana achatterjee-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor copy-edit suggestions.

@@ -113,6 +113,10 @@ We recommend running a Compactor since a single Ingester creates 96 files per da

Example compactor configuration with GCS:

#### Delete Permissions

In the course of compacting index files, the compactor writes a new file and deletes the unoptimized ones. Therefore, ensure the compactor has appropriate permissions for deleting files, such as `s3:DeleteObject` for AWS S3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When compacting index files, the compactor writes a new file and deletes all unoptimized files. Ensure that the compactor has appropriate permissions for deleting files, for example, s3:DeleteObject permission for AWS S3.

@@ -154,6 +154,10 @@ Ingesters now expose a new RPC method that queriers use when the index type is `
Queriers generally roll out faster than ingesters, so if new queriers query older ingesters using the new RPC, the queries would fail.
To avoid any query downtime during the upgrade, rollout ingesters before queriers.

#### If running the compactor, ensure it has delete permissions for the object storage.

The compactor is an optional but suggested component combines and deduplicates the boltdb-shipper index files. In the course of compacting these, it writes a new file and deletes the unoptimized ones. Therefore, ensure the compactor has appropriate permissions for deleting files in this bucket, such as `s3:DeleteObject` for AWS S3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compactor is an optional but suggested component that combines and deduplicates the boltdb-shipper index files. When compacting index files, the compactor writes a new file and deletes all unoptimized files. Ensure that the compactor has appropriate permissions for deleting files, for example, s3:DeleteObject permission for AWS S3.

@cyriltovena cyriltovena added this to To do in Loki Project Oct 27, 2020
@cyriltovena cyriltovena moved this from To do to In progress in Loki Project Oct 27, 2020
Loki Project automation moved this from In progress to Reviewer approved Oct 27, 2020
Copy link
Contributor

@achatterjee-grafana achatterjee-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 3e5e461 into grafana:master Oct 27, 2020
Loki Project automation moved this from Reviewer approved to Done Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants