Docs: -querier.split-queries-by-day deprecation #2833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siavashs
requested review from
achatterjee-grafana and
oddlittlebird
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## master #2833 +/- ##
==========================================
+ Coverage 61.27% 61.31% +0.04%
==========================================
Files 179 179
Lines 14438 14438
==========================================
+ Hits 8847 8853 +6
+ Misses 4781 4778 -3
+ Partials 810 807 -3
|
owen-d
approved these changes
Oct 28, 2020
docs/sources/configuration/_index.md
Outdated
| @@ -310,6 +310,7 @@ The queryrange_config configures the query splitting and caching in the Loki que | |||
| # CLI flag: -querier.split-queries-by-interval | |||
| [split_queries_by_interval: <duration> | default = 0s] | |||
|
|
|||
| # Deprecated: Split queries by day and execute in parallel. | |||
There was a problem hiding this comment.
Suggested change
| # Deprecated: Split queries by day and execute in parallel. | |
| # Deprecated: Split queries by day and execute in parallel. Instead use `-querier.split-queries-by-interval`. |
There was a problem hiding this comment.
Change to: "Use -querier.split-queries-by-interval instead."
There was a problem hiding this comment.
Updated the note as suggested.
docs/sources/configuration/_index.md
Outdated
| @@ -310,6 +310,7 @@ The queryrange_config configures the query splitting and caching in the Loki que | |||
| # CLI flag: -querier.split-queries-by-interval | |||
| [split_queries_by_interval: <duration> | default = 0s] | |||
|
|
|||
| # Deprecated: Split queries by day and execute in parallel. | |||
There was a problem hiding this comment.
Change to: "Use -querier.split-queries-by-interval instead."
Add missing description and deprecation note.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing description and deprecation note.
Checklist