tests: fix quoting issues in test output when building with Go 1.15 #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
slim-bean
approved these changes
Oct 29, 2020
|
I am not sure the CI will pass with Go 1.14. It did only work with 1.15 locally. |
|
Not sure how we got that merged cause we are not using 1.15 yet in our build image and it will fail, actually it does fail on master. I'm curious what's going on our CI that this PR passed all checks ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While packaging Loki with Go 1.15 for NixOS I noticed that the quoting in the tests didn't match the new quoting that Go applies.
Which issue(s) this PR fixes:
Fixes #2519
Special notes for your reviewer:
Checklist