Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

production/ksonnet: Add config_hash annotation to gateway deployment based on gateway configmap #2852

Merged
merged 1 commit into from
Nov 5, 2020
Merged

production/ksonnet: Add config_hash annotation to gateway deployment based on gateway configmap #2852

merged 1 commit into from
Nov 5, 2020

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Oct 29, 2020

What this PR does / why we need it:

It adds a hash of the gateway configmap to the gateway deployment, causing a
rolling update on the gateway if the configmap changes.

This prevents stale configurations from being used and makes it easier to roll
out gateway configuration changes.

sandeepsukhani
sandeepsukhani approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chancez
Copy link
Contributor Author

chancez commented Nov 2, 2020 •
edited

The failure seems unrelated:

--- FAIL: Test/invalid_idle_duration (0.00s)
--
188 | metrics_test.go:247: Metrics stage validation error, expected error = max_idle_duration could not be parsed as a time.Duration: 'time: unknown unit "f" in duration "10f"', actual error = max_idle_duration could not be parsed as a time.Duration: 'time: unknown unit f in duration 10f'

@cyriltovena
Copy link
Contributor

Yeah I need to update the go version. I'll keep you posted.

@cyriltovena cyriltovena merged commit cb383d6 into grafana:master Nov 5, 2020
@chancez chancez deleted the gateway_config_hash branch November 5, 2020 17:54
@shokada shokada mentioned this pull request Nov 7, 2020
Merged
@halcyondude halcyondude mentioned this pull request Nov 9, 2020
Merged
cyriltovena pushed a commit that referenced this pull request Nov 9, 2020
@halcyondude
gateway: fix regression in tanka jsonnet (#2899)
80539a2 
Seeing the following when importing loki...

evaluating jsonnet: RUNTIME ERROR: {snip}everquoteinc/loki-du/tanka/vendor/loki/gateway.libsonnet:97:5-6 Unexpected: "$" while parsing field definition

Related to:

#2852
cb383d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeepsukhani sandeepsukhani sandeepsukhani approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chancez @cyriltovena @sandeepsukhani