Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(loki-mixin): refer to super.annotations #2873

Merged
merged 1 commit into from
Nov 5, 2020
Merged

fix(loki-mixin): refer to super.annotations #2873

merged 1 commit into from
Nov 5, 2020

Conversation

Duologic
Copy link
Member

@Duologic Duologic commented Nov 4, 2020 •
edited

What this PR does / why we need it:
see #2729

Which issue(s) this PR fixes:
fixes #2729

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

cyriltovena
cyriltovena approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 22fbfe2 into master Nov 5, 2020
@cyriltovena cyriltovena deleted the duologic/fix_2729 branch November 5, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mixin: operational dashboard fails to build
2 participants
@Duologic @cyriltovena