Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: add tail_proxy_url option to query_frontend_config section #2879

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Conversation

zhanghjster
Copy link
Contributor

What this PR does / why we need it:

Add tail_proxy_url option to query_frontend_config, It is supported but no doc.

Which issue(s) this PR fixes:
Fixes #2878

Special notes for your reviewer:

Checklist

  • Documentation added

@CLAassistant
Copy link

CLAassistant commented Nov 5, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

…proxy_url to the request header, because in some scenario queryFrontend forward tail to the queriers deployed behind nginx and "Host" is required.
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Nov 5, 2020
@codecov-io
Copy link

Codecov Report

Merging #2879 into master will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2879      +/-   ##
==========================================
- Coverage   61.35%   61.17%   -0.19%     
==========================================
  Files         181      181              
  Lines       14565    14569       +4     
==========================================
- Hits         8937     8913      -24     
- Misses       4809     4833      +24     
- Partials      819      823       +4     
Impacted Files Coverage Δ
pkg/loki/modules.go 3.50% <0.00%> (-0.05%) ⬇️
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️
pkg/promtail/targets/file/tailer.go 69.52% <0.00%> (-5.72%) ⬇️
pkg/promtail/targets/file/filetarget.go 64.08% <0.00%> (-2.12%) ⬇️
pkg/storage/stores/shipper/uploads/table.go 68.66% <0.00%> (-1.85%) ⬇️
...kg/storage/stores/shipper/uploads/table_manager.go 65.78% <0.00%> (-1.76%) ⬇️
pkg/querier/queryrange/downstreamer.go 97.64% <0.00%> (+2.35%) ⬆️

@cyriltovena cyriltovena merged commit bc202ae into grafana:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query-frontend does not support websockets/tailing
5 participants