Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip journald bad message. #2928

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

cyriltovena
Copy link
Contributor

Unfortunately I can't log the message itself without forking the library we are using.

@slim-bean what do you think ? not sure that's enough for forking, we could do an upstream contribution should we ?

Fixes #2812.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Unfortunatelly I can't show the message itself without forking the library
we are using.

Fixes grafana#2812.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@slim-bean slim-bean self-assigned this Nov 17, 2020
@slim-bean slim-bean added this to the 2.1 milestone Nov 17, 2020
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promtail stops shipping logs when an error is encountered in journald
3 participants