Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup labels parsing. #2929

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Conversation

cyriltovena
Copy link
Contributor

Make sure we only use one type of labels parsing.
This just reduce the amount of code we have to maintain.

We can also now ensure that labels are sent to the ingester ordered, so no need for special equality.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Make sure we only use one type of labels parsing.This just reduce the amount of code we have to maintain.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #2929 (b5ee538) into master (049c7ac) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2929      +/-   ##
==========================================
- Coverage   61.76%   61.74%   -0.03%     
==========================================
  Files         181      181              
  Lines       14731    14710      -21     
==========================================
- Hits         9098     9082      -16     
+ Misses       4801     4797       -4     
+ Partials      832      831       -1     
Impacted Files Coverage Δ
pkg/util/conv.go 72.72% <ø> (+22.72%) ⬆️
pkg/distributor/distributor.go 75.91% <100.00%> (ø)
pkg/distributor/validator.go 90.24% <100.00%> (ø)
pkg/ingester/instance.go 56.62% <100.00%> (-0.18%) ⬇️
pkg/ingester/mapper.go 93.10% <100.00%> (+4.06%) ⬆️
pkg/ingester/transfer.go 58.91% <100.00%> (ø)
pkg/querier/queryrange/downstreamer.go 95.29% <0.00%> (-2.36%) ⬇️
pkg/logql/evaluator.go 91.24% <0.00%> (-0.41%) ⬇️

@cyriltovena cyriltovena merged commit e1ab2cc into grafana:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants