[Helm Chart Loki] Add needed k8s objects for alerting config #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
czunker
force-pushed
the
add_alerting
branch
from
02bbde6
to
f00ac44
Compare
Codecov Report
@@ Coverage Diff @@
## master #2965 +/- ##
==========================================
- Coverage 61.75% 61.74% -0.02%
==========================================
Files 182 182
Lines 14866 14866
==========================================
- Hits 9181 9179 -2
- Misses 4838 4840 +2
Partials 847 847
|
czunker
force-pushed
the
add_alerting
branch
from
f00ac44
to
ef8457f
Compare
|
CI failed on cloning fluent-bit-amd64. So, nothing I can fix. Is there a way to recheck? |
- ConfigMap containing the rules - VolumeMount for rules - scratch mount for rule parsing Fixes grafana#2964 Signed-off-by: Christian Zunker <christian.zunker@codecentric.cloud>
czunker
force-pushed
the
add_alerting
branch
from
ef8457f
to
12ca716
Compare
cyriltovena
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2964
Signed-off-by: Christian Zunker christian.zunker@codecentric.cloud
Checklist