Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the ruler storage with the boltdb store. #3008

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

cyriltovena
Copy link
Contributor

This ensure we have read-only local index, and also query chunk store from ingesters. Found this bug while deploying a new cluster using the ruler and boltdb store.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

This ensure we have read-only local index, and also query chunk store from ingesters. Found this bug while deploying a new cluster using the ruler and boltdb store.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #3008 (f6e1b07) into master (8c1fe88) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3008      +/-   ##
==========================================
+ Coverage   62.39%   62.40%   +0.01%     
==========================================
  Files         185      185              
  Lines       15614    15614              
==========================================
+ Hits         9742     9744       +2     
+ Misses       4944     4943       -1     
+ Partials      928      927       -1     
Impacted Files Coverage Δ
pkg/loki/modules.go 3.44% <0.00%> (ø)
pkg/querier/queryrange/limits.go 95.83% <0.00%> (+4.16%) ⬆️

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@owen-d owen-d merged commit dcbfecf into grafana:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants