Fixes promtail mixin dashboard. #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3010 +/- ##
==========================================
+ Coverage 62.37% 62.43% +0.06%
==========================================
Files 185 185
Lines 15624 15624
==========================================
+ Hits 9745 9755 +10
+ Misses 4953 4943 -10
Partials 926 926
|
owen-d
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e14463b removed a metric that was used previously in a dashboard could not find a better way yet to use the new metric so instead I added back the recording rules.
Also fixes a missing template expansion from 899e8cc.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com