-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first_over_time and last_over_time #3050
Conversation
This is an attempt to allow users to select the first or last discrete sample values from a range vector. This way we can create gauge, the only drawback being the log need to exists at least in every range. May be we could transfer the last or first value to the next range, but it will still be a problem for small ranges. Still wondering how useful this is compare to min/max_over_time. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@grafana/loki-team WDYT ? |
what kind of problems we talking about for small ranges? you mean in terms of performance? |
If you want to build some sort of gauge with logs, then you need to have the log exist in every range, you're selecting otherwise you'll have gaps if not no value at all. |
I'm open to it. Part of me wants us to wait until we see real use case requests for this but my suspicion is this will be a helpful addition. |
I don't recall having a use-case for this, but perhaps it was within another related topic. |
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
@slim-bean I guess we're going forward with this ? To me it seems to resolve a problem. |
Alright the use-case we found is to show a gauge based of a log of stream. Currently it's almost possible with max or min but that doesn't give really the last seen value. |
Codecov Report
@@ Coverage Diff @@
## master #3050 +/- ##
==========================================
- Coverage 63.25% 63.21% -0.04%
==========================================
Files 188 188
Lines 16304 16314 +10
==========================================
Hits 10313 10313
- Misses 5051 5062 +11
+ Partials 940 939 -1
|
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
How does this overlap with the feature of the |
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
This is an attempt to allow users to select the first or last discrete sample values from a range vector.
This way we can create gauge, the only drawback being the log need to exists at least in every range.
May be we could transfer the last or first value to the next range, but it will still be a problem for small ranges.
Still wondering how useful this is compare to min/max_over_time.
WDYT @slim-bean and @chancez you both wanted this feature, I'm still not sure.