Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the moduleManager field public #3077

Merged

Conversation

MichelHollands
Copy link
Contributor

Signed-off-by: Michel Hollands michel.hollands@grafana.com

Currently new modules cannot be added in code based on Loki.

Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
@codecov-io
Copy link

Codecov Report

Merging #3077 (f89738c) into master (6c8ad52) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3077      +/-   ##
==========================================
+ Coverage   62.80%   62.83%   +0.02%     
==========================================
  Files         186      186              
  Lines       15949    15949              
==========================================
+ Hits        10017    10021       +4     
+ Misses       5005     4999       -6     
- Partials      927      929       +2     
Impacted Files Coverage Δ
pkg/loki/loki.go 0.00% <0.00%> (ø)
pkg/logql/evaluator.go 89.87% <0.00%> (-0.36%) ⬇️
pkg/canary/comparator/comparator.go 78.18% <0.00%> (+1.81%) ⬆️
pkg/querier/queryrange/downstreamer.go 97.64% <0.00%> (+2.35%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit e9001d8 into grafana:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants