Small fixes for the documentation. #3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3088 +/- ##
==========================================
- Coverage 62.86% 62.83% -0.04%
==========================================
Files 186 186
Lines 15949 15949
==========================================
- Hits 10026 10021 -5
- Misses 4996 4999 +3
- Partials 927 929 +2
|
kavirajk
reviewed
Jan 4, 2021
| @@ -1427,7 +1427,7 @@ memcached_client: | |||
|
|
|||
| # The maximum number of idle connections in the memcached client pool. | |||
| # CLI flag: -<prefix>.memcached.max-idle-conns | |||
| [max_idle_conns: <int> | default = 100] | |||
| [max_idle_conns: <int> | default = 16] | |||
There was a problem hiding this comment.
any rationale why we did that? just curious!
owen-d
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found those while working on the code base.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com