Wal/recover corruption #3117
Merged
Wal/recover corruption #3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3117 +/- ##
==========================================
+ Coverage 62.83% 62.87% +0.04%
==========================================
Files 186 186
Lines 15949 15961 +12
==========================================
+ Hits 10021 10036 +15
+ Misses 5000 4998 -2
+ Partials 928 927 -1
|
slim-bean
reviewed
Jan 4, 2021
slim-bean
reviewed
Jan 4, 2021
Co-authored-by: Ed Welch <ed@oqqer.com>
Co-authored-by: Ed Welch <ed@oqqer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a change which notes WAL recovery failures, but allows the process to continue after logging/incrementing metrics. It also simplifies some of the recovery code.
Notably this enables the ingester to optimistically recover what data it can, including allowing later data to recover after i.e. a segment failure. The mentioned metrics can be used with alerts, especially in conjunction with
quorum(replication_factor)to warn of data loss.